Site Editor: Display a notice if export fails #37131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Feature] Site Editor
|
Size Change: +77 B (0%) Total Size: 1.11 MB
ℹ️ View Unchanged
|
spacedmonkey
reviewed
Dec 6, 2021
| downloadjs( blob, 'edit-site-export.zip', 'application/zip' ); | ||
| } catch ( error ) { | ||
| const errorMessage = | ||
| error.message && error.code !== 'unknown_error' |
There was a problem hiding this comment.
There are mutiple error code that could be returned here.
- rest_cannot_export_templates - permission error.
- missing_zip_package - Unable to generate ZIP because of missing package.
- unable_to_create_zip - Unable to generate ZIP for unknown reasons.
Should there be different error messages here.
There was a problem hiding this comment.
@spacedmonkey, this is for default error message if the code is unknown. Otherwise, it will use messages returned from the server.
|
Error handling seem to work well in my testing. |
Mamaduka
force-pushed
the
add/site-export-error-notice
branch
from
4aaed20 to
2de0c08
Compare
|
Hi, @spacedmonkey Is this PR in good shape to merge? |
spacedmonkey
approved these changes
Dec 7, 2021
noisysocks
removed
the
Backport to WP 6.7 Beta/RC
noisysocks
pushed a commit
that referenced
this pull request
Dec 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR adds error handling for Site Editor export functionality.
P.S. I've also extracted the Export menu item into a separate component for convenience
How has this been tested?
Screenshots
Types of changes
Bugfix
Checklist:
*.native.jsfiles for terms that need renaming or removal).