Group, Columns: Lower specificity of padding rules further. #37356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
the
[Type] Code Quality
jasmussen
commented
Dec 14, 2021
| @@ -85,8 +81,8 @@ | |||
| > .wp-block-column { | |||
| // Available space should be divided equally amongst columns. | |||
| flex-basis: 0; | |||
| flex-grow: 1; | |||
There was a problem hiding this comment.
I don't know why this changed, I didn't touch this piece. May have been tweaked by a linter.
jasmussen
referenced
this pull request
in WordPress/twentytwentytwo
Dec 14, 2021
|
Size Change: +5 B (0%) Total Size: 1.11 MB
ℹ️ View Unchanged
|
oandregal
approved these changes
Dec 15, 2021
|
Thank you! |
ZebulanStanphill
added
the
CSS Styling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Followup to #34854, and inspired by WordPress/twentytwentytwo@395e093#r61847726.
The group and columns blocks both add a default padding when a background is applied. Using
:whereit already had pretty low specificity. But it can be lower still, and this PR does so. By wrapping both the block and the background class to the where selector, the specificity is now low enough that the 60px margin wins out in the following example, despite the default padding rule being after the 60px rule:How has this been tested?
Test group and columns blocks with and without a background applied. Verify no visual changes otherwise.
Checklist:
*.native.jsfiles for terms that need renaming or removal).