Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scripts: Exclude BEM class from stylelint @wordpress/scripts #37531

Merged
merged 2 commits into from
Apr 20, 2022

Conversation

khoipro
Copy link
Contributor

@khoipro khoipro commented Dec 20, 2021

Description

I pushed a patch for fixing #35485.

How has this been tested?

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Dec 20, 2021
@github-actions
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @khoipro! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@khoipro khoipro changed the title Fix #35485 - exclude BEM class Fix #35485 - exclude BEM class from stylelint @wordpress/scripts Dec 20, 2021
@gziolo
Copy link
Member

gziolo commented Dec 22, 2021

See my comment in the parent issue:

Should we revisit #28954 instead that tried to make the rule better aligned with what Gutenberg uses? An alternative would be to disable the rule everywhere (in @wordpress/stylelint-config) until we have a better validator.

@gziolo gziolo added [Package] stylelint config /packages/stylelint-config [Package] Scripts /packages/scripts [Type] Enhancement A suggestion for improvement. labels Feb 11, 2022
@gziolo gziolo changed the title Fix #35485 - exclude BEM class from stylelint @wordpress/scripts Scripts: Exclude BEM class from stylelint @wordpress/scripts Apr 20, 2022
Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's land it as a temporary solution.

@gziolo gziolo merged commit ee7618d into WordPress:trunk Apr 20, 2022
@github-actions
Copy link

Congratulations on your first merged pull request, @khoipro! We'd like to credit you for your contribution in the post announcing the next WordPress release, but we can't find a WordPress.org profile associated with your GitHub account. When you have a moment, visit the following URL and click "link your GitHub account" under "GitHub Username" to link your accounts:

https://profiles.wordpress.org/me/profile/edit/

And if you don't have a WordPress.org account, you can create one on this page:

https://login.wordpress.org/register

Kudos!

@github-actions github-actions bot added this to the Gutenberg 13.1 milestone Apr 20, 2022
@khoipro khoipro deleted the fix/stylelint-config branch April 28, 2022 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Package] Scripts /packages/scripts [Package] stylelint config /packages/stylelint-config [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants