Remove the Large style option from the quote block #37580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carolinan
added
[Type] Enhancement
|
Size Change: +10.3 kB (+1%) Total Size: 1.14 MB
ℹ️ View Unchanged
|
ntsekouras
reviewed
Dec 23, 2021
There was a problem hiding this comment.
Thanks for the PR @carolinan !
I think you should add a comment in quote styles that the specific styles are kept for backwards compatibility and this would be good to go.
What is interesting though is that if we have content with a non existing style (like this) and we change a style later, both styles are kept because of this: https://github.com/WordPress/gutenberg/blob/trunk/packages/block-editor/src/components/block-styles/utils.js#L47. This is not related to the PR. --cc @ramonjd
Thanks for the ping. I didn't work on that particular method (assuming you're referring to this one, just to confirm), but I'm happy to look at it when I get time as I have spent some time splashing about in block styles recently. 👍 |
@ramonjd I'm referring to |
Ah no worries! Thanks again for the clarification. I've added it to the list. 🙇 |
|
So, from what I can tell replaceActiveStyle() will only remove an existing style className, in this instance, Because the "large" style no longer exists in the collection in this PR, there is no "valid" existing style and the className won't be removed. The first thing that came to mind is to treat the This will of course delete any user-defined classes beginning with Perhaps the Quote Block could take care of its own deprecation by checking When refactoring Pullquote I did something similar if memory serves me correct, which it might not. 🤣 This opens up a wider question: is there a preferred path for deprecating block styles? |
ntsekouras
reviewed
Jan 27, 2022
There was a problem hiding this comment.
👋 thanks Carolina! This tests well and my only concern is my previous comment:
What is interesting though is that if we have content with a non existing style (like this) and we change a style later, both styles are kept
What if we add the below as a temp solution at least, since we don't have a mechanism for deprecating styles and I'm not even sure if we need to, at this point..
&.is-style-large:not(.is-style-plain),
&.is-large:not(.is-style-plain)
This way if we had older Quote blocks with the large style and click plain the styles change. --cc @jasmussen
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes the large style option from the quote block.
The style can no longer be selected from the UI, but the CSS class and style is kept.
Closes #37202
-This was a small code change, so I'm wondering if I missed a step.
How has this been tested?
Tested manually by placing the following code in the block editor:
The large style should no longer be selectable in the editor, but should work when the
.is-style-largeCSS class is added.The plain and default styles should still be available,
All three quote styles should look correct in the editor and on the front.
(There is an unrelated problem with the right aligned text for the large style)
Screenshots
Types of changes
Enhancement
Checklist:
*.native.jsfiles for terms that need renaming or removal).