Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Fix broken URL on block variation page #37702

Merged
merged 1 commit into from
Jan 4, 2022
Merged

Docs: Fix broken URL on block variation page #37702

merged 1 commit into from
Jan 4, 2022
+1 −1

Conversation

Mamaduka
Copy link
Member

@Mamaduka Mamaduka commented Jan 4, 2022 •
edited
Loading

Description

PR fixed a broken URL on the blocks variation page.

It looks like we don't generate documentation pages for block editor component readmes. So I just linked it directly to GitHub.

How has this been tested?

See render view of the documentation

Types of changes

Documentation update

@Mamaduka Mamaduka added the [Type] Developer Documentation Documentation for developers label Jan 4, 2022
@Mamaduka Mamaduka self-assigned this Jan 4, 2022
mkaz
mkaz approved these changes Jan 4, 2022
View reviewed changes
Copy link
Member

@mkaz mkaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing 👍

Here's an old ticket open around sub-component documentation:
#15107

@mkaz mkaz merged commit 028b6b6 into trunk Jan 4, 2022
@mkaz mkaz deleted the fix/docs-block-variation-picker-url branch January 4, 2022 13:47
@github-actions github-actions bot added this to the Gutenberg 12.4 milestone Jan 4, 2022
@Mamaduka
Copy link
Member Author

Mamaduka commented Jan 4, 2022

Thanks, @mkaz. I didn't know about the original issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkaz mkaz mkaz approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

Assignees

@Mamaduka Mamaduka

Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Milestone
Gutenberg 12.4
Development

Successfully merging this pull request may close these issues.
2 participants
@Mamaduka @mkaz