Fix aria-modal attribution with multiple navs on page #37813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tellthemachines
requested review from
vcanales,
talldan,
alexstine and
carolinan
tellthemachines
added
[Block] Navigation
tellthemachines
added
the
Backport to WP 6.7 Beta/RC
|
Size Change: +4 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
|
@tellthemachines Code looks sane to me and makes sense. However, I am not sure how to setup multiple navs given the existing A11Y issues in the back-end. Can you throw together a quick test site by any chance or know someone who may be able to? Thanks. |
|
@alexstine I haven't managed to install the plugin zip generated by this PR; it seems to be missing a file or two. One thing you can try is add a couple of Navigation blocks in the body of a post; if you use the "add all pages" option from the block placeholder you won't need to add any content to them. Then save and view the post on the front end. Let me know if that doesn't work for you, and I'll try and sort out a test site tomorrow. |
alexstine
approved these changes
Jan 11, 2022
noisysocks
removed
the
Backport to WP 6.7 Beta/RC
noisysocks
pushed a commit
that referenced
this pull request
Jan 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #36600 (last step in fixing this issue, mostly it was addressed in #37434)
If there is more than one Navigation block on the page, the dialog attribute is always attached to the first one. This PR fixes it so attributes are always attached to the correct block.
How has this been tested?
aria-modal="true"androle="dialog"are added to that overlay (they should be on thewp-block-navigation__responsive-dialogelement) and not the other navigation block.Screenshots
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist:
*.native.jsfiles for terms that need renaming or removal).