Add the WP version in which some JS APIs will be removed #37854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Code Quality
|
Size Change: +24 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
|
I think this is a good way to go 👍🏻 The console is a good dev oriented messaging place and this here promotes a good practice of announcing version of expiring things. |
aristath
approved these changes
Jan 11, 2022
ntsekouras
approved these changes
Jan 11, 2022
Mamaduka
approved these changes
Jan 11, 2022
37 tasks
|
@youknowriad What to you think about addeing this also to to the Dev Notes section?Besides the placement, if you have better and more accurate wording, I'd apprecite the correction. Slated to be removed in 6.2 are:The APIs listed have been deprecated in WordPredd 5.3 and were forward them to the new ones already. They will be entirely removed in WordPress 6.2.
|
|
@bph sounds good to me 👍 |
|
@youknowriad I think the notes might be a little confusing... The notes make it sound like every import from With that in mind, I've updated my code imports from However, when I switch from A few examples: // works fine, no deprecation message
select('core/editor').getPermalink()
// FAILS
select('core/block-editor').getPermalink()
// works fine, no deprecation message
wp.data.select('core/editor').getCurrentPostId()
// FAILS
wp.data.select('core/block-editor').getCurrentPostId()
// works fine, no deprecation message
const currentPost = useSelect(
select => select('core/editor').getCurrentPost(),
[]
);
const { editPost } = useDispatch( 'core/editor');
// FAILS
const currentPost = useSelect(
select => select('core/block-editor').getCurrentPost(),
[]
);
const { editPost } = useDispatch( 'core/block-editor'); |
|
Now, as I work through these updates, I also see that import {
mediaUpload,
} from '@wordpress/editor';also isn't throwing any deprecation error. Is it possible to be more specific as to which things are getting deprecated, if it's not everything in those packages? |
|
@jakeparis I see how that could be confusing. If it helps, most of the APIs related to blocks moved from the editor to the block-editor package in 5.3. A lot of the APIs related to posts remain in the editor package and are not deprecated. Some of those you can also use the core-data package for. |
|
Were these APIs actually removed in 6.2? I don't see any mention of them being removed in the 'Removal of deprecated APIs and Components' section of the 'Miscellaneous Editor Changes in WordPress 6.2' blog post (published 2023-03-07) or in the 'WordPress 6.2 Field Guide' blog post (published 2023-03-09) more generally. (The 'Block Editor miscellaneous Dev Notes for WordPress 6.0' blog post published 2022-05-07 does indicate they will be removed and gives instructions for replacing them.) |
|
Most of these were not removed because there's still a lot of plugins using them. We need to probably update the expiration date or remove it for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In previous WordPress versions, we've removed JS APIs that we deprecated between WP 5.0 and 5.3 but we kept some APIs that were deemed impactful.
In this PR, I'm adding an "expiration date" for these APIs. Basically I'm saying that we will be removing these APIs in WP 6.2 to warn plugin authors.
These messages appear in the console, so they could potentially be considered not visible enough? On the alternative side, these APIs were deprecated like 3 years ago and plugins authors have had enough (and will have) time to see the messages (unless they're completely ignoring their plugin).
Any thoughts on the approach? @WordPress/gutenberg-core