Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Try: Add sticky position support for the Group block #38039

Closed
wants to merge 8 commits into from
Closed

[WIP] Try: Add sticky position support for the Group block #38039

wants to merge 8 commits into from

Commits on Feb 17, 2022

  1. Try: Add sticky position support for the Group block

    @andrewserong @oandregal
    andrewserong authored and oandregal committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    e68b33c View commit details
    Browse the repository at this point in the history

  2. Try moving position support to layout

    @andrewserong @oandregal
    andrewserong authored and oandregal committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    c4f7a81 View commit details
    Browse the repository at this point in the history

  3. New settings (works in WordPress 5.8)

    @oandregal
    oandregal committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    e2a1890 View commit details
    Browse the repository at this point in the history

  4. New settings (works in WordPress 5.9) 

    Rename wp_get_global_settings to gutenberg_get_global_settings.

In WordPress 5.9 the wp_* function is already defined,
so we can't override them. It's calling the existing
WP_Theme_JSON classes in WordPress core so it won't pick up
the plugin modification.

In the plugin, to make sure these changes work fine in 5.9
as well, we need to use the gutenberg_* function instead.
    @oandregal
    oandregal committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    cf100a2 View commit details
    Browse the repository at this point in the history

  5. New styles (works in WordPress 5.8)

    @oandregal
    oandregal committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    3e935bd View commit details
    Browse the repository at this point in the history

  6. New styles (works in WordPress 5.9)

    @oandregal
    oandregal committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    f20fa0c View commit details
    Browse the repository at this point in the history

  7. Fix for WordPress 5.9: gutenberg_get_global_stylesheet should call th… 

    …e Gutenberg classes
    @oandregal
    oandregal committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    ca41acf View commit details
    Browse the repository at this point in the history

  8. Fix lint issues

    @oandregal
    oandregal committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    ac46fc2 View commit details
    Browse the repository at this point in the history