-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new Testing Instructions section to PR template. #38147
Conversation
We already have "How has this been tested" which is supposed to cover this. I like the copy that you wrote better, though. How about we delete "How have this been tested" and keep "Testing instructions"? |
@noisysocks Sounds good. Updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a good improvement, so giving it the thumbs up 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm all for this. I still find too many PRs where the author describes that they have tested it rather than how the reviewer should test it.
Thanks for the PR!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is a good improvement. Let's merge it
Description
This adds a new section called Testing Instructions to the PR template. That way contributors can better understand exactly how to test a PR by following simple steps.
How has this been tested?
GitHub template change.
Screenshots
Types of changes
Workflow modification.
Checklist:
*.native.js
files for terms that need renaming or removal).