Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new Testing Instructions section to PR template. #38147

Merged
merged 4 commits into from
Jan 25, 2022

Conversation

alexstine
Copy link
Contributor

Description

This adds a new section called Testing Instructions to the PR template. That way contributors can better understand exactly how to test a PR by following simple steps.

How has this been tested?

GitHub template change.

Screenshots

Types of changes

Workflow modification.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).
  • I've updated related schemas if appropriate.

@alexstine alexstine added [Type] Enhancement A suggestion for improvement. Needs Decision Needs a decision to be actionable or relevant [Type] Project Management Meta-issues related to project management of Gutenberg labels Jan 21, 2022
@alexstine alexstine self-assigned this Jan 21, 2022
@noisysocks
Copy link
Member

We already have "How has this been tested" which is supposed to cover this. I like the copy that you wrote better, though. How about we delete "How have this been tested" and keep "Testing instructions"?

@alexstine
Copy link
Contributor Author

@noisysocks Sounds good. Updated.

@alexstine alexstine requested a review from talldan January 25, 2022 05:05
Copy link
Contributor

@talldan talldan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good improvement, so giving it the thumbs up 👍

Copy link
Contributor

@getdave getdave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm all for this. I still find too many PRs where the author describes that they have tested it rather than how the reviewer should test it.

Thanks for the PR!

Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a good improvement. Let's merge it :shipit:

@Mamaduka Mamaduka merged commit 62b8326 into trunk Jan 25, 2022
@Mamaduka Mamaduka deleted the add/testing-instructions-pr-template branch January 25, 2022 10:28
@github-actions github-actions bot added this to the Gutenberg 12.5 milestone Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Decision Needs a decision to be actionable or relevant [Type] Enhancement A suggestion for improvement. [Type] Project Management Meta-issues related to project management of Gutenberg
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants