-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP Add/text orientation block support #38319
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
Size Change: +286 B (0%) Total Size: 1.15 MB
ℹ️ View Unchanged
|
ramonjd
force-pushed
the
add/text-orientation-block-support
branch
from
January 30, 2022 23:57
15830f9
to
a98faff
Compare
ramonjd
force-pushed
the
add/text-orientation-block-support
branch
from
February 9, 2022 05:45
f46e92c
to
c452fa0
Compare
This was referenced Feb 10, 2022
9 tasks
ramonjd
force-pushed
the
add/text-orientation-block-support
branch
from
February 18, 2022 02:46
c452fa0
to
fbe8c60
Compare
ramonjd
commented
Feb 18, 2022
@@ -47,6 +47,7 @@ | |||
"__experimentalFontWeight": true, | |||
"__experimentalLetterSpacing": true, | |||
"__experimentalTextTransform": true, | |||
"__experimentalWritingMode": true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just for testing purposes for now.
ramonjd
force-pushed
the
add/text-orientation-block-support
branch
from
February 22, 2022 01:47
3d3d77c
to
177d2b9
Compare
Marking this as stale. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on:
Description
This is a WIP/experiment to add a new
writingMode
block support.Reference: https://developer.mozilla.org/en-US/docs/Web/CSS/writing-mode
Initially we're adding it to permit design goals, with the layout/i18n aspects to come.
See also:
TODO
Testing Instructions
Opt-in to
writingMode
support intheme.json
In the site and post editors, insert a paragraph block, then toggle the "Orientation" controls in the Typography panel.
Ensure what you see in the editors is what you get in the frontend.
Screenshots
Types of changes
Checklist:
*.native.js
files for terms that need renaming or removal).