Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Layout: use CSS logical properties for margin top and bottom #38816

Merged
merged 5 commits into from
Mar 10, 2022
Merged

Layout: use CSS logical properties for margin top and bottom #38816

merged 5 commits into from
Mar 10, 2022

Commits on Mar 10, 2022

  1. Layout doesn't take into account different writing modes, such as lef… 

    …t-to-right, vertical and so on. With CSS logical properties, block and inline margins will apply to the appropriate side depending on the direction of the document flow. This change to the layout margins ensures that margins will adhere to the logic of current flow. For example, margin-block-start (instead of margin-top) will manifest itself as a top margin for `writing-mode: horizontal-tb;` but a right margin for `writing-mode: vertical-rl;`.
    @ramonjd
    ramonjd committed Mar 10, 2022
    Configuration menu
    Copy the full SHA
    fb10c49 View commit details
    Browse the repository at this point in the history

  2. Fixing CSS error where I mean to use margin-inline-end for margin-rig… 

    …ht. Other minor formatting

Taking a clumsy stab at compat files so we can load the global styles and settings.
    @ramonjd
    ramonjd committed Mar 10, 2022
    Configuration menu
    Copy the full SHA
    1d13855 View commit details
    Browse the repository at this point in the history

  3. Updated tests and removed var_dumpy

    @ramonjd
    ramonjd committed Mar 10, 2022
    Configuration menu
    Copy the full SHA
    32d3ed8 View commit details
    Browse the repository at this point in the history

  4. Removing reference to non-existent file after rebasing on top of #38883 

    Removing `get_stylesheet()` from WP_Theme_JSON_Gutenberg
    @ramonjd
    ramonjd committed Mar 10, 2022
    Configuration menu
    Copy the full SHA
    c675f30 View commit details
    Browse the repository at this point in the history

  5. Removing the CSS logical properties for styles that control horizonta… 

    …l page layout (left and right margins) so that any changes to the writing mode of blocks within wp-site-blocks and block containers still align themselves according to current horizontal rules.
    @ramonjd
    ramonjd committed Mar 10, 2022
    Configuration menu
    Copy the full SHA
    0616be3 View commit details
    Browse the repository at this point in the history