Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor classic menu conversion process #38858

Merged
merged 18 commits into from
Mar 7, 2022
Merged

Refactor classic menu conversion process #38858

merged 18 commits into from
Mar 7, 2022

Commits on Mar 3, 2022

  1. Refactor hook to single async function

    @getdave
    getdave committed Mar 3, 2022
    Configuration menu
    Copy the full SHA
    b0a7d1d View commit details
    Browse the repository at this point in the history

  2. Adjust UI state vars to account for conversion process state

    @getdave
    getdave committed Mar 3, 2022
    Configuration menu
    Copy the full SHA
    124e244 View commit details
    Browse the repository at this point in the history

  3. Unify menu ref update process

    @getdave
    getdave committed Mar 3, 2022
    Configuration menu
    Copy the full SHA
    ffa8a7e View commit details
    Browse the repository at this point in the history

  4. Remove superceeded hook

    @getdave
    getdave committed Mar 3, 2022
    Configuration menu
    Copy the full SHA
    34974ac View commit details
    Browse the repository at this point in the history

  5. Refactor conversion state to enum

    @getdave
    getdave committed Mar 3, 2022
    Configuration menu
    Copy the full SHA
    c8a8e1c View commit details
    Browse the repository at this point in the history

  6. Add initial error handling for conversion process

    @getdave
    getdave committed Mar 3, 2022
    Configuration menu
    Copy the full SHA
    8161482 View commit details
    Browse the repository at this point in the history

  7. i18n of classic menu fetch error

    @getdave
    getdave committed Mar 3, 2022
    Configuration menu
    Copy the full SHA
    651ed4c View commit details
    Browse the repository at this point in the history

  8. Handle more creation errors

    @getdave
    getdave committed Mar 3, 2022
    Configuration menu
    Copy the full SHA
    27d0a94 View commit details
    Browse the repository at this point in the history

  9. Manually hoist var

    @getdave
    getdave committed Mar 3, 2022
    Configuration menu
    Copy the full SHA
    6fad279 View commit details
    Browse the repository at this point in the history

  10. Add accessible menu import announcements

    @getdave
    getdave committed Mar 3, 2022
    Configuration menu
    Copy the full SHA
    04bdbc2 View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2022

  1. Refactor to remove useReducer in favour of simple useState 

    Addresses #38858 (comment)
    @getdave
    getdave committed Mar 4, 2022
    Configuration menu
    Copy the full SHA
    35cbf10 View commit details
    Browse the repository at this point in the history

  2. Fix bug where constants were accidentally assigned to constants

    @getdave
    getdave committed Mar 4, 2022
    Configuration menu
    Copy the full SHA
    864a469 View commit details
    Browse the repository at this point in the history

  3. Simplify menu selector props 

    Detect the classic menu by relying on it’s `auto_add` prop which we know will not be defined on a Navigation Post.
    @getdave
    getdave committed Mar 4, 2022
    Configuration menu
    Copy the full SHA
    987c38f View commit details
    Browse the repository at this point in the history

  4. Improve error handling

    @getdave
    getdave committed Mar 4, 2022
    Configuration menu
    Copy the full SHA
    31ccf02 View commit details
    Browse the repository at this point in the history

  5. Use constants over comparisons for statuses

    @getdave
    getdave committed Mar 4, 2022
    Configuration menu
    Copy the full SHA
    5ae5df7 View commit details
    Browse the repository at this point in the history

  6. Extract common function for handling selecting a Navigation

    @getdave
    getdave committed Mar 4, 2022
    Configuration menu
    Copy the full SHA
    bf69385 View commit details
    Browse the repository at this point in the history

  7. Optimise handler

    @getdave
    getdave committed Mar 4, 2022
    Configuration menu
    Copy the full SHA
    ef9b3d7 View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2022

  1. Remove unwanted conditional operator

    @getdave
    getdave committed Mar 7, 2022
    Configuration menu
    Copy the full SHA
    ca5eeb5 View commit details
    Browse the repository at this point in the history