Fix incorrect meta box position when switching device preview #38910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +4 B (0%) Total Size: 1.15 MB
ℹ️ View Unchanged
|
jasmussen
approved these changes
Mar 2, 2022
There was a problem hiding this comment.
Giving tentative approval to this one. I managed to test this in Safari 13.1 using Browserstack, and not only does it look like the original issue (see #33817 for more info) isn't easily reproducible, but in fact that some other issues are fixed in Safari 13 by applying this patch.
Before, notice the overlapping metabox after exiting desktop:
https://cldup.com/qOUkNqBuJd.gif
After, notice it's fixed:
https://cldup.com/ZeouSHun1S.gif
That said, this PR reverts an aspect of the PR that was meant to fix the very same issue. Hopefully the answer is that this rule was necessary after all, and the other aspects of 33817 were sufficient.
But it'd nevertheless be good to test this one in both block and classic themes in a variety of circumstances. This would also be a PR to watch and be mindful of in upcoming releases.
Thanks for your work here!
carolinan
added
[Type] Bug
Mamaduka
added
the
Backport to WP Minor Release
adamziel
removed
the
Backport to WP Minor Release
|
Removing the backport label in here as it is already a part of the gutenberg/packages/edit-post/src/components/visual-editor/index.js Lines 126 to 128 in 2c2970e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tries to solve #38062, where meta boxes would be positioned incorrectly, covering the content.
Testing Instructions
and that it is not stuck in the middle of the page, covering content.
Before this can be merged, it should be tested on Safari 13 (macOS 10.15 Catalina). Unless we decide that the current bug is more important to solve.
Screenshots
See the screencast for 5.9 in #38062 (comment) to confirm that the issue can not be reproduced.
Types of changes
Bug fix
Checklist:
*.native.jsfiles for terms that need renaming or removal).