-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Framework: Update npm packages to remove warnings from the console #3908
Conversation
@@ -40,14 +40,13 @@ describe( 'BlockIcon', () => { | |||
} ); | |||
|
|||
it( 'renders a component', () => { | |||
class MyComponent extends Component { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eslint had some issues with having this inlined ...
45:5 error Your render method should have return statement react/require-render-return
"react-redux": "5.0.6", | ||
"react-transition-group": "1.2.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like it is no longer used. I removed it.
"babel-plugin-lodash": "3.2.11", | ||
"babel-plugin-transform-object-rest-spread": "6.26.0", | ||
"babel-plugin-transform-react-jsx": "6.24.1", | ||
"babel-plugin-transform-runtime": "6.23.0", | ||
"babel-preset-env": "1.6.0", | ||
"babel-traverse": "6.26.0", | ||
"check-node-version": "3.1.1", | ||
"codecov": "2.3.0", | ||
"codecov": "3.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we still using this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we display badge in Readme based on it.
Description
Fixes #3107. This PR updates a few npm packages to get rid of npm warnings:
There is still one warning logged on the console:
It comes from the
enzyme
package which I updated to the latest version. I would wait until it's resolved on theenzyme
side.It also fixes new lint option for Jest:
How Has This Been Tested?
npm test
&npm dev
still work.Tested manually in the browser.
Checklist: