Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add focus mode for Navigation Menus #39286

Merged
merged 4 commits into from
Jun 16, 2023
Merged

Add focus mode for Navigation Menus #39286

merged 4 commits into from
Jun 16, 2023

Commits on Jun 15, 2023

  1. Add new state handlers for setting Nav Menu 

    Fixing unlocking

Avoid unnecessarily effectful code

Fix bug with persistent Nav block locking

Reinstate effect to limit calls to selectBlock

Reinstate effect to run selectively

Isolate Nav specific code

Refactor settings to hook

Isolate Editor Canvas to component

Extract mode statuses to hook

Colocate editor canvas dependencies

Remove requirement for Nav hook to return data

Extract entire canvas to component

Get blocks directly from the store

Use factory to provide default editor component

Extract independent components for default and wp_navigation

Remove template dep from Navigation focus hook

Delete redundant hook

Remove need for settings prop

Extract hooks to files

Export boolean to avoid render

Remove redundant prop and var

Extract Site Editor Canvas component to file

Extract factory to file

Remove need to pass props to abstract component

Improve abstract component and factory naming

Improve usage of constants

Be explicit about entity mapping in factory

Remove templateType prop from SiteEditorCanvas component

Improve variable naming

Use more performant selector

Improve documenting rule for showing appender

Move Navigation specific editor settings to relevant provider

Remove useSiteEditorMode hook

See #39286 (comment)

Reintstate bug fix with comment

Fix error in rebase

Add edit button

Use Navigation icon and label

Use correct labels
    @getdave @scruffian
    getdave authored and scruffian committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    04e1104 View commit details
    Browse the repository at this point in the history

  2. Add descriptive text as instructed 

    See #39286
    @getdave
    getdave committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    62612cf View commit details
    Browse the repository at this point in the history

  3. Update edit link for Navigation post type 

    Fixes revisions link
    @getdave
    getdave committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    9ff74da View commit details
    Browse the repository at this point in the history

  4. Fix PHPCS

    @getdave
    getdave committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    a0fdf18 View commit details
    Browse the repository at this point in the history