Test/optional ignore style validation #39417
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glendaviesnz
added
the
[Status] In Progress
|
Size Change: +5.39 kB (0%) Total Size: 1.16 MB
ℹ️ View Unchanged
|
|
Thanks for the PR @glendaviesnz I think the important thing to figure out right now is what do we really want to do with the "style" invalidation: 1- Do we want to allow block authors to consider changes to the style markup valid? Personally, I think if we do consider moving all "style" attributes to the server, it would create a lot of noise if we don't provide automatic migrations. Meaning, I think we should do one of these two approaches:
That said, I've been thinking that maybe we're putting the cart before the horse. Basically, maybe we should actually do the change (style engine v2 and move style to the server in an opt-in way) and then decide what to do with the invalidation when we switch the style server flag for a given block. |
Yes, and some of the work currently being done on validation by Dennis will also feed into these decisions, eg. #38794, #38923, #39523
I tend to agree. I think I will just close this PR for now - knowing how the move of styles is actually going to work via the style engine will help better inform exactly what is needed in terms of the validation handling. |
7 tasks
25 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Just a rough prototype to see if we can make ignoring styles in validation optional by block.
Related to #37942
Why?
How?
Testing Instructions
Screenshots or screencast