Add Navigation menu to known entities #39498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +22 B (0%) Total Size: 1.16 MB
ℹ️ View Unchanged
|
5 tasks
adamziel
approved these changes
Mar 16, 2022
|
We have menus, menu items, menu locations, navigation menus – it is getting confusing. Would you please add a few comments inside entities.js to explain how are these different from each other? |
adamziel
reviewed
Mar 16, 2022
| @@ -175,6 +175,14 @@ export const rootEntitiesConfig = [ | |||
| baseURLParams: { context: 'edit' }, | |||
| key: 'plugin', | |||
| }, | |||
| { | |||
| label: __( 'Navigation' ), // Block based Navigation Menus | |||
There was a problem hiding this comment.
Is it a post type? If so, do we refer to it with kind="postType" in other packages?
There was a problem hiding this comment.
It's a custom post type yes. That's why it's
wp.data.select('core').getEntityRecords('postType','wp_navigation')
There was a problem hiding this comment.
It's a custom post type yes. That's why it's
wp.data.select('core').getEntityRecords('postType','wp_navigation')
There was a problem hiding this comment.
In this case this needs a follow up to replace all the getEntityRecords('postType','wp_navigation') calls for the getEntityRecords('root','navigationMenus').
But thinking more about this – introducing two different ways to refer to the same thing will likely lead to, well, two different ways of using it. Shall we rollback this PR and instead hardcode a shortcut that would refer to the postType, wp_navigation pair?
getdave
force-pushed
the
add/navigation-menu-entity
branch
from
ed3e2e0
to
be9d317
Compare
|
Rebasing in the hope that the e2e tests have been fixed on |
|
I revert this PR in #39572 because it appeared to cause a regression whereby Templates wouldn't load in the Site Editor. |
getdave
added a commit
that referenced
this pull request
Mar 18, 2022
getdave
added a commit
that referenced
this pull request
Mar 21, 2022
getdave
added a commit
that referenced
this pull request
Mar 22, 2022
jostnes
pushed a commit
to jostnes/gutenberg
that referenced
this pull request
Mar 23, 2022
* Add Navigation menu to known entities * Add comments for clarity Addresses WordPress#39498 (comment)
getdave
added a commit
that referenced
this pull request
Mar 24, 2022
getdave
added a commit
that referenced
this pull request
Mar 28, 2022
getdave
added a commit
that referenced
this pull request
Mar 28, 2022
…enus (#39290) * Navigation: try adding dedicated sidebar for managing layout of navigation menus * Fix table width to avoid overflow * Iterate on var naming and code comments * Further naming refinement * More var renaming * Rename panel title for clarity * Improve a11y of component * Revert addition of fixed table layout. Introduces too many visual bugs * Wrap items to avoid off screen movers where possible * Move additional padding * Revert id on ListView This is now handled in #39494 * Use standard getEntityRecords and remove custom entity selector Now moved to #39498 * Add handling for no data or limited data * Collapse all Nav nodes by default * Only show empty message when there are no menus * Guard against editing unpublished Menus * Select Gallery block in list view correctly * Remove rebase artifact * Add empty message in case of empty menu Co-authored-by: Dave Smith <getdavemail@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR adds a new
navigationMenusentity (wp_navigation) to the list of "known" entities. This enables use of selector "shortcuts" to fetch Navigation Menus.Why?
Spun out of #39290 in order to simplify that PR.
We often want to fetch data about Navigation Menus. To do this we have to write out the full
getEntityRecords()providing all the correct parameters. This is rather verbose and requires remember all the correct params:Given that
wp_navigationis now part of WP Core it makes sense to add a shortcut to enable shorthand selectors.With this PR we can now achieve the same result with the following selector:
How?
By adding the new entity to the root entity records
core-datawill generate a selector which will fetch Navigation Menus.Testing Instructions
First verify that Navigatoin Menus are available in the root entity records.
navigationMenuentry.Now check you can call the shortcut selector to return available Navigation posts.
Also verify you can utilise the singular form of the selector:
Screenshots or screencast