Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate block editor insert usage to preferences store #39632

Open
wants to merge 12 commits into
base: trunk
Choose a base branch
from
Open

Migrate block editor insert usage to preferences store #39632

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
b7746d5
Migrate block editor insert usage to preferences store
talldan Mar 22, 2022
7b77cf8
Fix block editor actions tests
talldan Jul 15, 2024
c248301
Fix frecency test
talldan Jul 15, 2024
35f769f
Minimize properties in test assertions
talldan Jul 15, 2024
0973730
Ensure markNextChangeAsExpensive is called and update tests
talldan Jul 15, 2024
776ce33
Fix only track allowedBlocks in insertBlocks action
talldan Jul 15, 2024
01c8545
Simplify sort callback
talldan Jul 15, 2024
e53f940
Update debouncing function - use trailing edge debounce only and impl…
talldan Jul 15, 2024
152c653
Fix persistence layer tests
talldan Jul 17, 2024
8535582
Update docs
talldan Jul 18, 2024
ff68aa1
Fix resetting of preferences in e2e test
talldan Jul 18, 2024
f33d99c
Hide the welcome guide in e2e test
talldan Jul 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions test/e2e/specs/site-editor/activate-theme.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,12 @@ test.describe( 'Activate theme', () => {
await expect( page.locator( '.edit-site-canvas-loader' ) ).toHaveCount(
0
);
// Usually `visitSiteEditor` is used to test the site editor, and it
// hides the welcome guide. Since this test uses a different flow,
// manually update the preferences here.
await editor.setPreferences( 'core/edit-site', {
welcomeGuide: false,
} );
Comment on lines +42 to +44
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test actually fails in trunk if you run it locally. It only passes in CI in trunk because other tests that run before it set welcomeGuide to false 😬

I'm not sure why it started failing on CI in this PR.

await editor.canvas.locator( 'body' ).click();
await page
.getByRole( 'region', { name: 'Editor top bar' } )
Expand Down
Loading