Revert "Global styles: remove block gap control" #39845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit dcad2b4.
ramonjd
added
the
Global Styles
youknowriad
reviewed
Mar 29, 2022
|
Size Change: +105 B (0%) Total Size: 1.22 MB
ℹ️ View Unchanged
|
|
Do you know why the root gap support regressed? Seems like it's important to fix that (to avoid WP 6.0 regression) |
…ey do not work on the frontend. We do this by checking for a block name and then returning false.
We only noticed it recently, but think it was after this PR was merged: Specifically, this line: 'spacing' => array(
....
'blockGap' => 'top', // <- this will be skipped when adding to `$schema['styles']['blocks']`
),There's a comment in The current thinking is that we do something in layout to get around this. Documented in: |
|
I think maybe we should merge this one for now, just in case we run into any blockers in the follow up: |
apeatling
approved these changes
Mar 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #39601
Was meant to be temporary, but probably a hammer where we need a scalpel.
For now we're checking for a block name, e.g.,
core/groupand returning false fromuseGapin order to hide the block gap controls for block-level global styles.Looking at block-level gap support over in: