Quote v2: add align feature to have feature parity with v1 #39876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oandregal
requested review from
ellatrix,
youknowriad,
ntsekouras and
jorgefilipecosta
and removed request for
ajitbohra
|
Size Change: +22 B (0%) Total Size: 1.22 MB
ℹ️ View Unchanged
|
ellatrix
approved these changes
Mar 30, 2022
youknowriad
reviewed
Mar 30, 2022
| /** | ||
| * WordPress dependencies | ||
| */ | ||
| import { InnerBlocks, RichText, useBlockProps } from '@wordpress/block-editor'; | ||
|
|
||
| export default function save( { attributes } ) { | ||
| const { citation } = attributes; | ||
| const blockProps = useBlockProps.save(); | ||
| const { align, citation } = attributes; |
There was a problem hiding this comment.
It's so bad that this attribute is called "align" instead of "textAlign" as "align" is also a reserved attribute for the block alignments hook. But I guess that's probably not limited to v2 of quote and may exist in other blocks too.
There was a problem hiding this comment.
Yeah, this is a v1 attribute so I didn't want to change now that we're focused on bringing the minimum changes possible to v2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR adds the ability to align the contents of the quote v2, similarly to what's possible with v1.
Why?
We want to have feature parity.
How?
Uses the existing
alignattribute to attach the classes oneditandsavefunctions.Testing Instructions