Fix list-view focus radius. #39969
Merged
Fix list-view focus radius. #39969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
[Type] Bug
jasmussen
commented
Apr 1, 2022
| @@ -106,7 +121,7 @@ | |||
| left: 0; | |||
| border-radius: inherit; | |||
| box-shadow: inset 0 0 0 var(--wp-admin-border-width-focus) var(--wp-admin-theme-color); | |||
| z-index: 1; | |||
| z-index: 2; | |||
There was a problem hiding this comment.
This change was necessary for the focus style to not be cropped.
|
Size Change: +82 B (0%) Total Size: 1.22 MB
ℹ️ View Unchanged
|
jameskoster
approved these changes
Apr 1, 2022
mtias
approved these changes
Apr 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
#35170 enabled the ellipsis in list view. In doing so, instead of having a single
tdelement in atr, there were two, and so the blue background color was moved fromtdtotr.Unfortunately,
tris unaffected by border radius, so the 2px border radius stopped working:This PR fixes that, mostly:
I haven't found a good way to apply the bottom two corners of the light blue background, so those are still square.
Testing Instructions
Test the list view and observe rounded corners.