Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parser: Client-side wpautop #4005

Merged
merged 2 commits into from
Jan 30, 2018
Merged

Parser: Client-side wpautop #4005

merged 2 commits into from
Jan 30, 2018

Commits on Jan 30, 2018

  1. Framework: Drop server-side block serialization, wpautop 

    A parsed block has no awareness of where inner blocks exist in its innerHTML, so it cannot safely reserialize.

There are a few options:

- Since we merely skip wpautop for known blocks, we could avoid reserialization and return the block's original HTML verbatim if we had access to its outerHTML. See nylen/phpegjs#3

- Move wpautop behavior for freeform content to the editor client. This may align well with desires to transparently upgrade legacy paragraph content to paragraph blocks. This would also allow the server to avoid any preprocessing before showing a post on the front-end, assuming that the saved content has had wpautop applied already.

Acknowledging that this effectively reverts large parts of #2806
    @aduth
    aduth committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    0869e44 View commit details
    Browse the repository at this point in the history

  2. Parser: Apply autop to fallback block content

    @aduth
    aduth committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    222068e View commit details
    Browse the repository at this point in the history