Global Styles: Fix alignment of Global Styles color controls #40081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronrobertshaw
added
[Type] Bug
|
Size Change: +2 B (0%) Total Size: 1.22 MB
ℹ️ View Unchanged
|
andrewserong
approved these changes
Apr 6, 2022
There was a problem hiding this comment.
Thanks for the fix @aaronrobertshaw! I didn't realise that the underlying Flex component defaults to expanded: true to set width to 100%. In this case the ColorIndicatorWrapper should be the width of its content to allow the flex item containing the text to sit appropriately next to it, so that makes sense to me 👍
| Before | After |
|---|---|
 |
 |
LGTM!
|
Thank you @aaronrobertshaw and @andrewserong , definitely an overlook on my side. 🙇 |
ciampo
approved these changes
Apr 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related:
What?
Fixes broken layout of global styles color controls caused by #39982.
Why?
Looks nicer when text isn't forced outside the control.
How?
Maintains the change in approach added in #39982 however this PR sets the
expandedprop on theColorIndicatorWrappertofalseso that it adapts better while keeping the vertical alignment intended by the original PR.Testing Instructions
Screenshots or screencast