Theme Export: Change the schema url #40106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oandregal
approved these changes
Apr 6, 2022
37 tasks
mcsf
reviewed
Feb 6, 2024
| @@ -104,11 +104,11 @@ function gutenberg_generate_block_templates_export_file() { | |||
| // If a version is defined, add a schema. | |||
| if ( $theme_json_raw['version'] ) { | |||
| global $wp_version; | |||
| $theme_json_version = substr( $wp_version, 0, strpos( $wp_version, '-' ) ); | |||
| $theme_json_version = 'wp/' . substr( $wp_version, 0, 3 ); | |||
There was a problem hiding this comment.
What happens when WordPress reaches version 10?
@scruffian: I spotted this today in Core while looking at other things. Can we fix this? Something like this is enough:
- $theme_json_version = 'wp/' . substr( $wp_version, 0, 3 );
+ $theme_json_version = 'wp/' . substr( $version, 0, strpos( $version, '-' ) );There was a problem hiding this comment.
Created a core patch here: https://core.trac.wordpress.org/ticket/60486
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This fixes a mistake from #39775. Rather than using a complicated split to work out the version number, we can just take the first three digits of the version number...
Testing Instructions
See #39775