Plugin: Ensure that PHP code for blocks is correctly assigned to WP releases #40179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
added
[Feature] Blocks
gziolo
requested review from
ajitbohra,
mkaz,
ryanwelcher and
juanmaguitar
as code owners
gziolo
commented
Apr 8, 2022
| * @param array $metadata Metadata for registering a block type. | ||
| * @return array Metadata for registering a block type with the supports shape updated. | ||
| */ | ||
| function gutenberg_migrate_old_typography_shape( $metadata ) { |
There was a problem hiding this comment.
Added to WordPress core in 5.8.0 release:
https://github.com/WordPress/wordpress-develop/blob/22fbb4a9ae877610f35fa5908c36839d9631674c/src/wp-includes/blocks.php#L1040-L1045
gziolo
commented
Apr 8, 2022
| * | ||
| * @return boolean Whether or not the feature is supported. | ||
| */ | ||
| function gutenberg_block_has_support( $block_type, $feature, $default = false ) { |
There was a problem hiding this comment.
https://developer.wordpress.org/reference/functions/block_has_support/ was introduced in WordPress 5.8 and that is the minimum supported version for the plugin.
36 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Follow-up for #36176.
Part of #39889.
As part of this PR, I remove the usage of:
gutenberg_block_has_supportgutenberg_migrate_old_typography_shapefilter's callbackThey were added in WordPress 5.8.
I also moved block-related functionality to the appropriate compat layer files.
Why?
To ensure that compatibility layer functionality gets removed whenever we bump the minimum version of WordPress supported in the Gutenberg plugin.
How?
WordPres 5.9 compat:
_wp_normalize_relative_css_linksfunctionwp_enqueue_block_stylefunctiongutenberg_multiple_block_stylesfilter's callbackWordPres 6.0 compat (needs to be backported to WP core):
wp_enqueue_block_view_scriptfunctiongutenberg_block_type_metadata_multiple_view_scriptsfilter's callbackTesting Instructions
No functional changes. The plugin should still work as before.