Block patterns REST endpoint: use snake case for field names #40254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsnajdr
requested review from
TimothyBJacobs,
spacedmonkey and
nerrad
as code owners
|
There is also #40252 from @ntsekouras that changes the namespace for endpoints. |
gziolo
added
Core REST API Task
9 tasks
gziolo
reviewed
Apr 12, 2022
lib/compat/wordpress-6.0/class-wp-rest-block-patterns-controller.php
Outdated
Show resolved
Hide resolved
|
Size Change: +59 B (0%) Total Size: 1.22 MB
ℹ️ View Unchanged
|
ntsekouras
approved these changes
Apr 12, 2022
|
I landed #40252 so there are conflicts to resolve now. |
jsnajdr
force-pushed
the
update/block-patterns-rest-field-names
branch
from
019b6fd
to
ab8fe2a
Compare
rebased and resolved ✅ |
|
Nice, thank you. Let's wait for the CI checks and land it afterward. |
adamziel
pushed a commit
that referenced
this pull request
Apr 12, 2022
* Block patterns REST endpoint: use camel case for field names * fix formatting Co-authored-by: ntsekouras <ntsekouras@outlook.com>
adamziel
removed
the
Backport to WP 6.7 Beta/RC
|
This was cherry-picked to 13.0 RC3 |
pento
pushed a commit
to WordPress/wordpress-develop
that referenced
this pull request
Apr 12, 2022
Backports the same changes applied in Gutenberg: WordPress/gutenberg#40254. Follow-up for [53152]. Props jsnajdr, timothyblynjacobs. See #55505. git-svn-id: https://develop.svn.wordpress.org/trunk@53154 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Apr 12, 2022
Backports the same changes applied in Gutenberg: WordPress/gutenberg#40254. Follow-up for [53152]. Props jsnajdr, timothyblynjacobs. See #55505. Built from https://develop.svn.wordpress.org/trunk@53154 git-svn-id: http://core.svn.wordpress.org/trunk@52743 1a063a9b-81f0-0310-95a4-ce76da25c4cd
gMagicScott
pushed a commit
to gMagicScott/core.wordpress-mirror
that referenced
this pull request
Apr 12, 2022
Backports the same changes applied in Gutenberg: WordPress/gutenberg#40254. Follow-up for [53152]. Props jsnajdr, timothyblynjacobs. See #55505. Built from https://develop.svn.wordpress.org/trunk@53154 git-svn-id: https://core.svn.wordpress.org/trunk@52743 1a063a9b-81f0-0310-95a4-ce76da25c4cd
37 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the patterns response fields to use
snake_case. The objects stored inWP_Block_Patterns_RegistryusecamelCase, then they are converted to snake case when writing the REST response, and then they are converted back to camel case when receiving into thecoredata store.Addresses review comment by @TimothyBJacobs here: https://github.com/WordPress/wordpress-develop/pull/2488/files/a3e5009510fc4bc1d1a14a51a1cc16bc637ddf10#r846393041