Try: Rename Navigation Menus to Navigation. #40413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
[Type] Enhancement
|
Size Change: +39 B (0%) Total Size: 1.23 MB
ℹ️ View Unchanged
|
mtias
approved these changes
Apr 18, 2022
|
Can we also say this is "beta", somehow? |
jasmussen
force-pushed
the
try/rename-navigation-menus-button
branch
from
2e850db to
87f76ec
Compare
|
Thanks for the review. I added a beta label, like Global Styles has: |
mtias
approved these changes
Apr 20, 2022
jasmussen
force-pushed
the
try/rename-navigation-menus-button
branch
from
87f76ec to
df1ecaa
Compare
This was referenced Jul 27, 2022
82 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Inspired by #40411.
The site editor top toolbar is space challenged when the text labels option is enabled:
The gap between buttons is already compressed for the same reason, and as such the space between "Navigation" and "Menus" can easily be interpreted as those being two separate buttons, "Navigation" and "Menus". This PR simplifies the label to just "Navigation":
The menu itself is unchanged:
Testing Instructions
Test the site editor and the text label option.