-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Block: Fix warnings and errors reported during scaffolding and validation #40479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
requested review from
ntwb,
ajitbohra,
mkaz,
ryanwelcher and
juanmaguitar
as code owners
April 20, 2022 13:36
Size Change: 0 B Total Size: 1.23 MB ℹ️ View Unchanged
|
gziolo
force-pushed
the
update/prettier-css
branch
from
April 20, 2022 14:13
3cec708
to
ce20046
Compare
7 tasks
gziolo
changed the title
Create Block: Fix linting issues reported by
Create Block: Fix warnings and errors reported during scaffolding and validation
Apr 20, 2022
wp-scripts
gziolo
added
[Tool] WP Scripts
/packages/scripts
[Tool] Prettier config
/packages/prettier-config
[Type] Code Quality
Issues or PRs that relate to code quality
labels
Apr 20, 2022
gziolo
force-pushed
the
update/prettier-css
branch
from
April 20, 2022 15:02
ce20046
to
6a8b580
Compare
ryanwelcher
approved these changes
Apr 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good to me
bph
added
the
Needs Dev Note
Requires a developer note for a major WordPress release cycle
label
Aug 10, 2022
I added the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Needs Dev Note
Requires a developer note for a major WordPress release cycle
[Tool] Create Block
/packages/create-block
[Tool] Prettier config
/packages/prettier-config
[Tool] WP Scripts
/packages/scripts
[Type] Code Quality
Issues or PRs that relate to code quality
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Replaces #37517.
Fixes #37516.
After I scaffold a block from the tutorial in Block Editor Handbook I see some concerning reports during installation:
There are also errors and warnings reported during linting:
Why?
Nobody likes to see errors or warnings reported on the terminal. It gives the false impressions that something is wrong 😄
How?
@wordpress/scripts
to remove potential security vulnerabilities.