Block Editor: Deprecate 'BlockColorsStyleSelector' component #40502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Code Quality
|
Size Change: +54 B (0%) Total Size: 1.23 MB
ℹ️ View Unchanged
|
youknowriad
approved these changes
Apr 21, 2022
bph
added
the
Needs Dev Note
|
I think this note should go in Block Editor misc post. Dev NoteWordPress 6.1 will deprecate the |
bph
added
has dev note
youknowriad
reviewed
Nov 9, 2023
| alternative: 'block supports API', | ||
| since: '6.1', | ||
| version: '6.3', | ||
| } ); |
There was a problem hiding this comment.
Hey, is it time to remove this API or if judged too impactful, consider extending the version.
There was a problem hiding this comment.
I thought we were no longer removing deprecated components and APIs.
There was a problem hiding this comment.
I'm not sure we've came to a concrete decision yet. If you want to keep it, then update the version maybe.
There was a problem hiding this comment.
I don’t feel a strong attachment to this component, but some people have strong feelings on public API removals.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
PR deprecates
BlockColorsStyleSelectorcomponent.Why?
It was introduced in #19894 but hasn't been used since #23044. Block developers should prefer using Block Supports API for colors.
WP.org plugin directory search yields a single result - https://wpdirectory.net/search/01G15G70PDWRPHM36Z464NP7PE.
Testing Instructions
You can use the following code to see deprecation message (please ignore errors):