Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken Page title for pages created inline within in Nav block #41063

Merged
merged 12 commits into from
May 20, 2022
Merged

Fix broken Page title for pages created inline within in Nav block #41063

merged 12 commits into from
May 20, 2022

Commits on May 20, 2022

  1. Decode entities not escape 

    Noting that we may need to revert this pending further investigation.
    @getdave
    getdave committed May 20, 2022
    Configuration menu
    Copy the full SHA
    43fb468 View commit details
    Browse the repository at this point in the history

  2. Escape at point of output

    @getdave
    getdave committed May 20, 2022
    Configuration menu
    Copy the full SHA
    6f02e82 View commit details
    Browse the repository at this point in the history

  3. Move decoding to where it is actually required

    @getdave
    getdave committed May 20, 2022
    Configuration menu
    Copy the full SHA
    85ccb91 View commit details
    Browse the repository at this point in the history

  4. Remove title escaping test. Now done at point of output.

    @getdave
    getdave committed May 20, 2022
    Configuration menu
    Copy the full SHA
    559f139 View commit details
    Browse the repository at this point in the history

  5. Consume the raw value for editing 

    Implemented following discussion with @youknowriad
    @getdave
    getdave committed May 20, 2022
    Configuration menu
    Copy the full SHA
    bdcd9e8 View commit details
    Browse the repository at this point in the history

  6. Remove entity decoding since consuming raw

    @getdave
    getdave committed May 20, 2022
    Configuration menu
    Copy the full SHA
    f57289d View commit details
    Browse the repository at this point in the history

  7. Revert. Make interoperable with existing implementation.

    @getdave
    getdave committed May 20, 2022
    Configuration menu
    Copy the full SHA
    83a05dc View commit details
    Browse the repository at this point in the history

  8. Add additional context to usages

    @getdave
    getdave committed May 20, 2022
    Configuration menu
    Copy the full SHA
    06fd7ba View commit details
    Browse the repository at this point in the history

  9. Explain usage of decode entities

    @getdave
    getdave committed May 20, 2022
    Configuration menu
    Copy the full SHA
    906a717 View commit details
    Browse the repository at this point in the history

  10. Tweak comments

    @getdave
    getdave committed May 20, 2022
    Configuration menu
    Copy the full SHA
    ee75bd5 View commit details
    Browse the repository at this point in the history

  11. Ensure aria label is also available on Draft Pages

    @getdave
    getdave committed May 20, 2022
    Configuration menu
    Copy the full SHA
    d29de3e View commit details
    Browse the repository at this point in the history

  12. Add test coverage for HTML chars on Draft Pages

    @getdave
    getdave committed May 20, 2022
    Configuration menu
    Copy the full SHA
    8703fa2 View commit details
    Browse the repository at this point in the history