Scripts: Convert file extension to js in block.json during build
#41068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torounit
requested review from
gziolo,
ntwb,
nerrad,
ajitbohra and
ryanwelcher
as code owners
|
Size Change: -1.76 kB (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
gziolo
reviewed
May 16, 2022
There was a problem hiding this comment.
Good idea to make it less error-prone. It's probably confusing whether to provide the path from the src folder or from the build folder when using non-standard extension 😅
At the moment, you could provide the path ending with .js and webpack would check also for other extensions, but I agree that having both cases covered will improve the experience.
There is one issue to resolve and we will be good to go. We also keep the history of changes in the CHANGEOG file:
https://github.com/WordPress/gutenberg/blob/trunk/packages/scripts/CHANGELOG.md#unreleased
gziolo
changed the title
block.json during build
gziolo
approved these changes
May 21, 2022
There was a problem hiding this comment.
This looks great!
We also keep the history of changes in the CHANGELOG file:
https://github.com/WordPress/gutenberg/blob/trunk/packages/scripts/CHANGELOG.md#unreleased
Do you need help with this part?
|
@gziolo I wrote a changelog. Is it OK like this? |
It's perfect! Thank you so much for handling this enhancement. What has been the experience with TypeScript and blocks so far? Do we need to add anything to the default configuration to make it simple to work with? |
westonruter
added a commit
that referenced
this pull request
May 23, 2022
…p-tests-config * 'trunk' of github.com:WordPress/gutenberg: (88 commits) Components: refactor `AlignmentMatrixControl` to pass `exhaustive-deps` (#41167) [RNMobile] Add 'Insert from URL' option to Image block (#40334) [RNMobile] Improvements to Getting Started Guides (#40964) Post Author Name: Add to and from Post Author transformations (#41151) CheckboxControl: Add unit tests (#41165) Improve inline documentation (#41209) Mobile Release v1.76.1 (#41196) Use explicit type definitions for entity configuration (#40995) Scripts: Convert file extension to js in `block.json` during build (#41068) Reflects revert in 6446878 (#41221) get_style_nodes should be compatible with parent method. (#41217) Gallery: Opt-in to axial (column/row) block spacing controls (#41175) Table of Contents block: convert line breaks to spaces in headings. (#41206) Add support for button elements to theme.json (#40260) Global Styles: Load block CSS conditionally (#41160) Update URL (#41188) Improve autocompleter performance (#41197) Site Editor: Set min-width for styles preview (#41198) Remove Navigation Editor screen from experiments page (#40878) Fix broken Page title for pages created inline within in Nav block (#41063) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Convert the file extensions of viewScript, script, and editScript in block.json to js.
Why?
If use
editorScript:index.tsxin block.json, it will build correctly, but register_block_type will not load the script. we will need to convert the value of theeditorScriptto the built file.How?
o convert block.json.
Convert block.json using transform in CopyWebpackPlugin