Prevent unexpected copying of the post title #41284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Bug
|
Size Change: +9.98 kB (+1%) Total Size: 1.28 MB
ℹ️ View Unchanged
|
|
The unit test failed, so I would like to find out where the mistake is. |
t-hamano
changed the title
|
@Mamaduka |
t-hamano
force-pushed
the
fix/get-selected-block-client-ids
branch
from
c4a7de0 to
ea31055
Compare
|
The rebasing passed all tests. |
|
I have confirmed that this problem still reproduces with the latest trunk. I have also confirmed that this PR will solve the problem. |
Mamaduka
requested review from
a team and
michalczaplinski
and removed request for
a team
|
Taking a look at this now! |
|
Thanks for the PR @t-hamano! I've tested it and confirmed that it fixes both issues as you described.
|
|
I don't think we should fix this by adding an exception to Is there an alternative way to fix this in Thinking more higher level, I think this is yet another example of why it was a mistake to implement widget areas using blocks 😅 See #33254. |
|
Thank you for the review, @michalczaplinski!
This PR prohibits the copying of the widget area itself, so the snack bar message itself does not appear to indicate that it has been copied. |
|
Hey @t-hamano ! Aside from the question of the user experience I'm afraid I'll have to side with @noisysocks here (thanks for chiming in Robert, btw!). Sorry about this! I didn't consider that the I'd still very much like to fix this issue but I'm not very familiar with the |
|
I am trying to solve this in the |
|
As for the widget area fix, I have yet to find a workable solution, so I have cut it out as a separate issue #45398, and reverted the changes. Also, perhaps I should not have addressed the two issues at the same time. Sorry for the confusion 🙏 |
t-hamano
changed the title
michalczaplinski
approved these changes
Oct 31, 2022
There was a problem hiding this comment.
The fix works great @t-hamano 👍
We can tackle the widgets issue in the other PR!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@edit: This PR originally attempted to solve the copying problem in the post title and the widget areas at the same time. However, I have decided to resolve the widget issues separately in a new issue #45398. For details, please see the edit history.
What?
This PR prevents copying of a post titles.
Why?
When text is selected in the post title,
getSelectedBlockClientIdsis executed.The post title is a block, but the
clientIdis empty, so the correct block name cannot be obtained at this point:https://github.com/WordPress/gutenberg/blob/trunk/packages/block-editor/src/components/copy-handler/index.js#L34
As a result, a message with an undefined value is displayed.
post-title.mp4
How?
Make
getSelectedBlockClientIdsreturn an empty array if clientId of the selected block is an empty string or undefined value.Testing Instructions
Ctrl(Cmd)+CorCtrl(Cmd)+X.