Post Comments Form: Add button that enables commenting to warning #41603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ockham
changed the title
|
Size Change: +170 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
ockham
commented
Jun 8, 2022
cbravobernal
approved these changes
Jun 13, 2022
There was a problem hiding this comment.
Nice job!
It is great to see it work, but, I guess this case is not really common.
As you have to:
1.) Add the comment form to a post. While the common case is to add it on the site editor.
2.) Have global comments enabled.
3.) Disable the comments in each post after adding the comment.
However, dealing with global settings as you mentioned could have huge benefits on the site editor part (as a post edition should not be able to change global settings, this could mess the site with side effects).
Should we explore that possibility for other use cases like Comments, Avatar, Date formatting, etc?
Yeah -- plus the post settings are easily available from the sidebar, so it's almost redundant 😅 This is really mostly to demo the principle, since it was one of the easiest settings to change via code.
👍
I would like to try that, yes! Issue #40614 has a whole list of other warnings; I'd definitely like to prioritize the ones that occur in the Site Editor. I'm just not sure if we even have actions available for dispatch for all of these 😅 (or even |
|
I'll hold off a bit longer before I merge as there's been a bit of a new development on this discussion: #41603 (comment). Maybe we can avoid the (loose) coupling with the editor store after all 😬 |
ockham
added
the
[Status] Blocked
ockham
removed
the
[Status] Blocked
|
Ready for another look 😄 |
mcsf
approved these changes
Jun 16, 2022
mcsf
approved these changes
Jun 17, 2022
ockham
force-pushed
the
add/post-comments-form-warning-enable-comments-button
branch
from
d72be81
to
d48277e
Compare
|
Trying a rebase to fix e2e failures. |
|
The remaining e2e failures seem unrelated (Navigation block); it looks like they're also present on |
ockham
added
the
Backport to WP Minor Release
adamziel
pushed a commit
that referenced
this pull request
Jun 21, 2022
…1603) Add a button to the Post Comments Form block that allows the user to enable commenting when it's disabled.
|
I just cherry-picked this PR to the wp/6.0 branch to get it included in the next release: 4970dcf |
adamziel
removed
the
Backport to WP Minor Release
10 tasks
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Add a button to the Post Comments Form block that allows the user to enable commenting when it's disabled.
Part of #40614; also the first experiment to explore whether a solution like this makes sense.
Why?
Remove frustration from the user coming from a warning message that doesn't give them agency to remediate the problem. See #40614 for more context.
How?
In the Post Comments Form block warning that states that commenting is not allowed, add a button that allows the user to enable it.
Testing Instructions
Note that this might not be the most interesting case from the list in #40614, since the "Allow comments" option is otherwise fairly easily accessible from the Post sidebar. However, we might apply the same principle (button in warning) to other cases where the corresponding setting isn't as readily availably (but e.g. somewhere in wp-admin > Settings > Discussion, see e.g. #41308).
Screenshots or screencast
Open questions