Block CSS: Move CSS from the stylesheet to the block definition #41689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scruffian
added
[Block] Embed
|
Size Change: -16 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
|
The rule (margin: 0 0 1em 0) seems to be applied, testing an emtpy theme. Block-CSS-styles-in-block-json.mp4 |
|
@bph I think that's expected, what did you expect? |
|
Yes. I didn't find anything not working. Confirming all as expected. 👏👏🚀👍 |
|
Yes. I didn't find anything not working. Confirming all as expected. 👏👏🚀👍 |
|
Thank you, that's very helpful :) |
|
The change here seems good. Howeover I'm encountering some awkward default margins as a result in TT2: Essentially the
In other words, the default bottom margin here conflicts with the owl selector ( Is that expected, or are there ways we can tweak this? Should the specificity be reduced one place or another, or increased for the owl selector? If I remove the new theme.json rules, things look good in TT2: But of course we risk resurfacing #29517. |
I think ideally the default margins provided by the blocks should have a lower specificity, rather than us increasing the specificity of the layout support. There's a semi-related issue for when folks do want margins to override layout styles (#43404) for which a solution might be to lower the specificity of the layout styles, but it's a challenging thing to do when wrestling with the block's default values, too. I'm not too sure how we get there, but from my perspective I think we'd want something like:
|
|
I created a PR to try to fix this bug here: #43792 |
bph
added
the
Needs Dev Note
|
I added the label |
|
@bph we did publish a post about it already: https://make.wordpress.org/core/2022/08/01/moving-core-block-styling-to-json/ Is that sufficient? |
|
I think this is covered by the dev note here: #34180 (comment) |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This moves the margin CSS for these 5 blocks from the stylesheet to the block.json file.
Why?
Now if a theme wants to override these rules they don't need to worry about CSS specificity, the rules in theme.json will simply change these values. This will also result in less CSS overall.
Testing Instructions
@WordPress/block-themers