Button Elements: Allow element styles in classic themes #42012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scruffian
added
the
Global Styles
scruffian
commented
Jun 28, 2022
| @@ -246,6 +246,9 @@ | |||
| "text": "#fff", | |||
| "background": "#32373c" | |||
| }, | |||
| "spacing": { | |||
| "padding": "calc(0.667em + 2px) calc(1.333em + 2px)" | |||
There was a problem hiding this comment.
I'm not sure what to do about this. In the theme I tested, the theme reset the padding for buttons. This padding is the one that used to be provided by the button block, but the search block uses a different padding. If we don't provide this then themes with heavy handed resets will lose button padding, but if we do provide this then the search block buttons will end up using this padding instead of the default specified in the block CSS. IMO this is a better compromise, but it will impact on the search button padding slightly.
There was a problem hiding this comment.
It is likely one of the smaller problems and I too agree that the second evil is lesser.
getdave
reviewed
Jun 29, 2022
draganescu
approved these changes
Jun 29, 2022
This was referenced Jun 30, 2022
|
I added a commit which moves the padding definition for the Search block button to the opinionated styles. This means that themes using this option won't be impacted. This follows on from the ideas discussed in #42054 |
|
Size Change: +566 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
bph
added
[Block] Buttons
37 tasks
|
This is actually an issue for classic themes that we're rediscussing at #43981 It seems that we haven't ported these changes to core as per https://github.com/WordPress/wordpress-develop/blob/trunk/src/wp-includes/global-styles-and-settings.php#L108 It's worth reevaluating this PR in light of the conversation at #43981 and revert if necessary to make sure classic themes do not get styles they don't want. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
In #34180, we moved block and element styles into JSON as well as migrating the styles of the
core/buttonsblock away from CSS and into these new formats.Classic themes don't load styles provided in JSON. This changes that, so that we now also include core only block and element styles from theme.json.
Why?
We need to ensure that the correct element styles are provided to all themes, not just block themes.
How?
Previously we only output variables and presets from theme.json, not the styles section. IMO it's safe to use this section as we restrict it to only the rules coming from the core styles, not from other origins:
Testing Instructions
Screenshots or screencast
The search block looks like this:
@WordPress/block-themers