-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lodash: Refactor away from _.fromPairs()
#42217
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Performance
Related to performance efforts
[Type] Code Quality
Issues or PRs that relate to code quality
[Package] Blocks
/packages/blocks
[Feature] Block Validation/Deprecation
Handling block validation to determine accuracy and deprecation
[Tool] Create Block
/packages/create-block
labels
Jul 7, 2022
tyxla
requested review from
aristath,
swissspidy,
chad1008,
andrewserong,
ntsekouras and
fabiankaegy
July 7, 2022 08:37
Size Change: +2 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
tyxla
force-pushed
the
remove/lodash-from-pairs
branch
from
July 11, 2022 07:35
bedfae6
to
6c46b60
Compare
tyxla
force-pushed
the
remove/lodash-from-pairs
branch
from
July 12, 2022 11:38
6c46b60
to
763bc24
Compare
chad1008
approved these changes
Jul 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Feature] Block Validation/Deprecation
Handling block validation to determine accuracy and deprecation
[Package] Blocks
/packages/blocks
[Tool] Create Block
/packages/create-block
[Type] Code Quality
Issues or PRs that relate to code quality
[Type] Performance
Related to performance efforts
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Lodash's
fromPairs
is used only a few times in the entire codebase. This PR aims to remove that usage.Why?
Lodash is known to unnecessarily inflate the bundle size of packages, and in most cases, it can be replaced with native language functionality. See these for more information and rationale:
@wordpress/api-fetch
package haslodash
as a dependency #39495How?
Removing
fromPairs
is straightforward in favor of a simpleObject.fromEntries()
replacement.Testing Instructions
create-block
still works well:npx @wordpress/create-block testblock
npm run test-unit test/integration/full-content/
npm run test-unit packages/blocks/src/api/test/validation.js