On template creation, don't show search if not needed #42357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Enhancement
|
Size Change: +29 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
Mamaduka
reviewed
Jul 12, 2022
packages/edit-site/src/components/add-new-template/add-custom-template-modal.js
Outdated
Show resolved
Hide resolved
jameskoster
approved these changes
Jul 12, 2022
There was a problem hiding this comment.
It's working for me:
Sidenote: The padding on the suggestions throws the alignment off in a way that's particularly awkward when there's no search box. Also, paragraphs having a top margin is making the space beneath the modal way too large. I'll probably open a PR to address these :D
|
@ntsekouras, I noticed the following warning in the console when testing this PR. |
Mamaduka
approved these changes
Jul 13, 2022
Thanks George! Created a quick PR about that: #42392 |
ntsekouras
force-pushed
the
update/on-template-creation-show-search-if-needed
branch
from
b928de5 to
0274cae
Compare
30 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Resolves: #42337
When creating a template for something like a Category, we should not render a search box if we have less than the initial results we suggest, as they are shown directly. The current number of the initial suggestions are
10.Before
After