Components: Improve docs for the SpaceInput type
#42376
Merged
+24
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirka
added
[Type] Developer Documentation
mirka
force-pushed
the
enhance/space-input-desc
branch
from
67de636 to
402f1e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #41882
What?
Improves the documentation for the
SpaceInputtype.Why?
Currently, one cannot correctly understand what
SpaceInputis unless they read the doc comment for thespace()utility function itself.How?
SpaceInputtype so that it is accurate.DividerandFlex.Spacerso it includes the fact that you can use a standard CSS string. (Not adding notes to all the props here because there are too many, and they are the main focus of the Spacer component 😄)Testing Instructions
npm run storybook:dev