-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Inserter displays block collections #42405
Commits on Jul 13, 2022
-
feat: Inserter display block collections
Collections of blocks regsitered via `registerBlockCollection` now appear at the end of the block inserter enabling additional organization of blocks.
Configuration menu - View commit details
-
Copy full SHA for 1216df2 - Browse repository at this point
Copy the full SHA 1216df2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 41343b0 - Browse repository at this point
Copy the full SHA 41343b0View commit details
Commits on Jul 14, 2022
-
fix: Update reusable blocks list data structure
The `BlockTypesList` now expects `sections` to support the `SectionList` used within it for displaying block collections. Prior to this change, an error was thrown.
Configuration menu - View commit details
-
Copy full SHA for c4af0f7 - Browse repository at this point
Copy the full SHA c4af0f7View commit details -
test: Fix failure by expanding selector mock
The `BlockTypesTab` now relies upon additional store selectors. The lack of mocks for these selectors caused test failures.
Configuration menu - View commit details
-
Copy full SHA for 35aa90b - Browse repository at this point
Copy the full SHA 35aa90bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7e678f1 - Browse repository at this point
Copy the full SHA 7e678f1View commit details -
refactor: Simplify and mirror web implementation
The code contained redundant selectors against the store for the block type list. This change refactors the native inserter to match the web counterpart, utilizing the selector leveraged by the web.
Configuration menu - View commit details
-
Copy full SHA for a2214a9 - Browse repository at this point
Copy the full SHA a2214a9View commit details -
refactor: Remove unnecessary object spread
While verbose, passing explicit props is likely more orthodox and straightforward to interpret.
Configuration menu - View commit details
-
Copy full SHA for e9944a9 - Browse repository at this point
Copy the full SHA e9944a9View commit details -
fix: Remove broken keyExtractor
The key for this component's sections is now `key`, not `id`, which resulted in undefined key values returned here. However, the default `keyExtractor` already searches for `key` and then `id`, so this can be safely removed.
Configuration menu - View commit details
-
Copy full SHA for 259c9a1 - Browse repository at this point
Copy the full SHA 259c9a1View commit details -
fix: Revert utilization of onSelect from useBlockTypesState
The block created from within this callback appears to be in a format that is incompatible with the native editor at this time. Specifically, this appeared to break Embed block variants, e.g. Vimeo. A future improvement would be to investigate this further in hopes of aligning web and native.
Configuration menu - View commit details
-
Copy full SHA for 4e03fee - Browse repository at this point
Copy the full SHA 4e03feeView commit details
Commits on Jul 15, 2022
-
chore: Add background to section headers
Improve legibility of section headers whenever blocks scroll beneath the header.
Configuration menu - View commit details
-
Copy full SHA for cc7fd83 - Browse repository at this point
Copy the full SHA cc7fd83View commit details -
chore: Display collection title to improve dark mode support
Leverage merely an icon with text made dark mode support more challenging. Rendering text allows for easy swapping of color schemes.
Configuration menu - View commit details
-
Copy full SHA for 576c6de - Browse repository at this point
Copy the full SHA 576c6deView commit details -
Configuration menu - View commit details
-
Copy full SHA for f044071 - Browse repository at this point
Copy the full SHA f044071View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4f28816 - Browse repository at this point
Copy the full SHA 4f28816View commit details