Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Inserter displays block collections #42405

Merged
merged 13 commits into from
Jul 15, 2022

Commits on Jul 13, 2022

  1. feat: Inserter display block collections

    Collections of blocks regsitered via `registerBlockCollection` now
    appear at the end of the block inserter enabling additional organization
    of blocks.
    dcalhoun committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    1216df2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    41343b0 View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2022

  1. fix: Update reusable blocks list data structure

    The `BlockTypesList` now expects `sections` to support the `SectionList`
    used within it for displaying block collections. Prior to this change,
    an error was thrown.
    dcalhoun committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    c4af0f7 View commit details
    Browse the repository at this point in the history
  2. test: Fix failure by expanding selector mock

    The `BlockTypesTab` now relies upon additional store selectors. The lack
    of mocks for these selectors caused test failures.
    dcalhoun committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    35aa90b View commit details
    Browse the repository at this point in the history
  3. docs: Add changelog entry

    dcalhoun committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    7e678f1 View commit details
    Browse the repository at this point in the history
  4. refactor: Simplify and mirror web implementation

    The code contained redundant selectors against the store for the block
    type list. This change refactors the native inserter to match the web
    counterpart, utilizing the selector leveraged by the web.
    dcalhoun committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    a2214a9 View commit details
    Browse the repository at this point in the history
  5. refactor: Remove unnecessary object spread

    While verbose, passing explicit props is likely more orthodox and
    straightforward to interpret.
    dcalhoun committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    e9944a9 View commit details
    Browse the repository at this point in the history
  6. fix: Remove broken keyExtractor

    The key for this component's sections is now `key`, not `id`, which
    resulted in undefined key values returned here. However, the default
    `keyExtractor` already searches for `key` and then `id`, so this can be
    safely removed.
    dcalhoun committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    259c9a1 View commit details
    Browse the repository at this point in the history
  7. fix: Revert utilization of onSelect from useBlockTypesState

    The block created from within this callback appears to be in a format
    that is incompatible with the native editor at this time. Specifically,
    this appeared to break Embed block variants, e.g. Vimeo. A future
    improvement would be to investigate this further in hopes of aligning
    web and native.
    dcalhoun committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    4e03fee View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2022

  1. chore: Add background to section headers

    Improve legibility of section headers whenever blocks scroll beneath the
    header.
    dcalhoun committed Jul 15, 2022
    Configuration menu
    Copy the full SHA
    cc7fd83 View commit details
    Browse the repository at this point in the history
  2. chore: Display collection title to improve dark mode support

    Leverage merely an icon with text made dark mode support more
    challenging. Rendering text allows for easy swapping of color schemes.
    dcalhoun committed Jul 15, 2022
    Configuration menu
    Copy the full SHA
    576c6de View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f044071 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    4f28816 View commit details
    Browse the repository at this point in the history