Writing flow: fix caret placement in corners #42437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
added
[Type] Bug
|
Size Change: +16 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
alexstine
approved these changes
Jul 14, 2022
|
Awesome, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Currently, when you move the caret up from the start of a paragraph to a paragraph with multiple lines, it moves the caret to the start of that paragraph. Instead, it should be placed at the bottom left corner.
Why?
How?
The problem is that we're trying to place the caret right at the edge. This doesn't work. We need to adjust the
xvalue slightly inwards.Testing Instructions
See above and e2e test.
Screenshots or screencast