Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style engine: enqueue block support styles #42452

Merged
merged 30 commits into from
Aug 2, 2022

Commits on Jul 29, 2022

  1. Configuration menu
    Copy the full SHA
    0840074 View commit details
    Browse the repository at this point in the history
  2. Linter, this one's for you.

    ramonjd authored and aristath committed Jul 29, 2022
    Configuration menu
    Copy the full SHA
    6a42821 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1f2b4a8 View commit details
    Browse the repository at this point in the history
  4. Removed spacing around curly braces in CSS rules. Updated tests.

    We could maybe add a prettify option down the road.
    
    Juggling methods around to cater for adding styles to (any) store.
    Also making return values consistent.
    ramonjd authored and aristath committed Jul 29, 2022
    Configuration menu
    Copy the full SHA
    5a51073 View commit details
    Browse the repository at this point in the history
  5. Splitting wp_style_engine_enqueue_block_supports_styles and `wp_sty…

    …le_engine_get_block_supports_styles` so we can enqueue styles that don't need parsing, e.g., layout
    ramonjd authored and aristath committed Jul 29, 2022
    Configuration menu
    Copy the full SHA
    55576b9 View commit details
    Browse the repository at this point in the history
  6. Integrate the processor class

    ramonjd authored and aristath committed Jul 29, 2022
    Configuration menu
    Copy the full SHA
    acc6209 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    7a22c5b View commit details
    Browse the repository at this point in the history
  8. Update packages/style-engine/class-wp-style-engine.php

    Co-authored-by: Ari Stathopoulos <aristath@gmail.com>
    ramonjd and aristath committed Jul 29, 2022
    Configuration menu
    Copy the full SHA
    7a6aa60 View commit details
    Browse the repository at this point in the history
  9. Tweaks for #42452 (#42691)

    * abstract stores
    
    * "else" not needed
    
    * compile_classnames method not needed
    
    * we have a method to get the store here
    
    * Make the wp_style_engine_add_to_store function always return a store
    
    * wp_style_engine_get_stylesheet - always return string
    
    * Merged with base branch.
    Added test for new method.
    
    Co-authored-by: ramonjd <ramonjd@gmail.com>
    Co-authored-by: Ramon <ramonjd@users.noreply.github.com>
    3 people committed Jul 29, 2022
    Configuration menu
    Copy the full SHA
    49b1433 View commit details
    Browse the repository at this point in the history
  10. Adding check for the context argument.

    Adding tests.
    ramonjd authored and aristath committed Jul 29, 2022
    Configuration menu
    Copy the full SHA
    d7893a6 View commit details
    Browse the repository at this point in the history
  11. Updating the processor so that it's ignorant of stores. Why? So that …

    …it can be used to process any CSS and not just stored CSS.
    
    Updating layout for backwards compatibility in gutenberg_get_layout_style (returning the styles that are collected in the function body only)
    Created a new mode for incoming $css_rules to be a collection of selector + css_declaration keys.
    Removed wp_style_engine_get_stylesheet (from store) since we don't use it yet
    Added a new function wp_style_engine_get_stylesheet_from_css_rules() that will process and compile a collection of CSS rules, and not store them.
    ramonjd authored and aristath committed Jul 29, 2022
    Configuration menu
    Copy the full SHA
    bc6e39a View commit details
    Browse the repository at this point in the history
  12. dump var_dump()

    ramonjd authored and aristath committed Jul 29, 2022
    Configuration menu
    Copy the full SHA
    e8a621d View commit details
    Browse the repository at this point in the history
  13. Improve the processor

    aristath committed Jul 29, 2022
    Configuration menu
    Copy the full SHA
    9ba5232 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    b41af7d View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    4ccf650 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2022

  1. remove unused variable

    Removing unused function wp_style_engine_get_stylesheet_from_store
    Updating tests to check for merging and deduping
    aristath authored and ramonjd committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    e30e4fb View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    062b920 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    5e4164a View commit details
    Browse the repository at this point in the history
  4. Revert get_instance() in wp_style_engine_add_to_store because we want…

    … to ensure the hook is enqueued here.
    ramonjd committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    fcebf93 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    d0d5fe5 View commit details
    Browse the repository at this point in the history
  6. Update lib/block-supports/layout.php

    Co-authored-by: Andrew Serong <14988353+andrewserong@users.noreply.github.com>
    ramonjd and andrewserong authored Aug 1, 2022
    Configuration menu
    Copy the full SHA
    e59eb10 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    5d7b827 View commit details
    Browse the repository at this point in the history
  8. Merge branch 'try/style-engine-enqueue-block-supports-styles' of gith…

    …ub.com:WordPress/gutenberg into try/style-engine-enqueue-block-supports-styles
    ramonjd committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    4d9f6c8 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    8d021ee View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    5f60026 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    a63f9cb View commit details
    Browse the repository at this point in the history
  12. Add a set_name method

    aristath committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    0eaef08 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    e4c791b View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    787f793 View commit details
    Browse the repository at this point in the history
  15. shorten it

    aristath committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    7dd5773 View commit details
    Browse the repository at this point in the history