Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style Engine: Rename WP_Style_Engine_CSS_Rule->set_declarations to add_declarations #42464

Merged
merged 1 commit into from
Jul 18, 2022

Conversation

aristath
Copy link
Member

What?

Renames the set_declarations method to add_declarations

Why?

set gives the impression that the declarations we're adding will replace the ones that existed. Instead, what the method does is to add declarations to the ones that already exist (and if none exist, then and only then can it be considered set).

@aristath aristath requested review from ramonjd and andrewserong July 15, 2022 10:42
@aristath aristath self-assigned this Jul 15, 2022
@ramonjd ramonjd added [Type] Code Quality Issues or PRs that relate to code quality [Package] Style Engine /packages/style-engine labels Jul 18, 2022
Copy link
Member

@ramonjd ramonjd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm setting adding my approval 😄

@ramonjd ramonjd merged commit 8dc70b4 into trunk Jul 18, 2022
@ramonjd ramonjd deleted the fix/style-engine/rename-set_declarations branch July 18, 2022 00:25
@github-actions github-actions bot added this to the Gutenberg 13.8 milestone Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Style Engine /packages/style-engine [Type] Code Quality Issues or PRs that relate to code quality
Projects
Status: 🏆 Done
Development

Successfully merging this pull request may close these issues.

2 participants