Style Engine: Rename WP_Style_Engine_CSS_Rule->set_declarations to add_declarations #42464
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Renames the
set_declarations
method toadd_declarations
Why?
set
gives the impression that the declarations we're adding will replace the ones that existed. Instead, what the method does is toadd
declarations to the ones that already exist (and if none exist, then and only then can it be consideredset
).