List v2: add forward delete #42564
Merged
List v2: add forward delete #42564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
added
[Type] Bug
|
Size Change: -189 B (0%) Total Size: 1.26 MB
ℹ️ View Unchanged
|
ellatrix
commented
Jul 20, 2022
| replaceBlocks( | ||
| [ listItemParentId ], | ||
| [ newListItemParent, ...newBlocksExcludingLast, newLastItem ] | ||
| ); |
There was a problem hiding this comment.
@jorgefilipecosta @ntsekouras I cleaned up outdenting to use moveBlocksToPosition. This has the benefit of keeping block client IDs and having to reapply selection. It's also a lot simpler and easier to follow.
packages/block-library/src/list-item/hooks/use-outdent-list-item.js
Outdated
Show resolved
Hide resolved
| const clientIds = _hasMultiSelection | ||
| ? getMultiSelectedBlockClientIds() | ||
| : [ clientId ]; | ||
| useCallback( ( clientIds = getSelectedBlockClientIds() ) => { |
There was a problem hiding this comment.
The hook useOutdentListItem( clientId ) already receives a clientId parameter. It feels strange that the callback the hook returns ignores the parameter and receives a similar parameter can we just make the hook receive clientIds defaulting to getSelectedBlockClientIds and keep the callback without parameters?
There was a problem hiding this comment.
Not sure I'm following here. The default is to outdent the selected blocks (clientIds = getSelectedBlockClientIds()), but we also need the ability to outdent specific blocks for forward Delete (outdent the next block).
jorgefilipecosta
approved these changes
Jul 21, 2022
There was a problem hiding this comment.
Left some comments/questions, but everything works great. Awesome work, @ellatrix 👍
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adds the ability to forward delete from the end of a list item. If the next line can be outdented, it will first be outdented. If it's at the top level, it will be merged.
Why?
Feature parity with List v1.
How?
Testing Instructions
Try forward delete (Fn+Backspace) from various positions.
Screenshots or screencast