Fix jsx-a11y label-has-associated-control configuration. #42671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afercia
added
[Type] Code Quality
|
Size Change: 0 B Total Size: 1.26 MB ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #42654
What?
#42654 removed the deprecated jsx-a11y rule
label-has-forin favor of the new rulelabel-has-associated-controlbut it also changed the rule configuration. This PR seeks to restore the original configuration.Why?
The configuration of the new rule
label-has-associated-controlis not equivalent to the one of the previouslabel-has-for, where it was required to associate labels to inputs by using for/id attributes. As established long time ago, we avoid wrapping labels because old assistive technology may not fully support that.How?
Makes the rule explicitly validate only the association with for/id attributes by passing the
assertoption. From the rule docs:https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/main/docs/rules/label-has-associated-control.md
Testing Instructions
packages/components/src/toggle-control/index.js, and remove thehtmlForprop.npm run lint-jsand see it errors.<label>element wrap the<FormToggle>component.npm run lint-jsand see it errors.npm run lint-jsand see it passes.Screenshots or screencast