Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove old WordPress 5.8 code #42818

Merged
merged 1 commit into from
Jul 29, 2022
Merged

Remove old WordPress 5.8 code #42818

merged 1 commit into from
Jul 29, 2022

Conversation

Soean
Copy link
Member

@Soean Soean commented Jul 29, 2022

The minimum is already WP 5.9 and gutenberg_is_global_styles_in_5_8() doen't exists anymore. So we can remove the check for WP 5.8.

@Soean Soean added the [Type] Code Quality Issues or PRs that relate to code quality label Jul 29, 2022
@Soean Soean requested a review from spacedmonkey as a code owner July 29, 2022 13:20
Mamaduka
Mamaduka approved these changes Jul 29, 2022
View reviewed changes
Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, @Soean!

The gutenberg_is_global_styles_in_5_8 function was removed in #41306, but not these checks.

@Soean Soean merged commit 8dec6c3 into trunk Jul 29, 2022
@Soean Soean deleted the remove-old-wp-5-8-code branch July 29, 2022 14:54
@github-actions github-actions bot added this to the Gutenberg 13.9 milestone Jul 29, 2022
@ockham ockham mentioned this pull request Aug 26, 2022
Closed
37 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mamaduka Mamaduka Mamaduka approved these changes

@spacedmonkey spacedmonkey Awaiting requested review from spacedmonkey spacedmonkey is a code owner

Assignees
No one assigned
Labels
[Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Milestone
Gutenberg 13.9
Development

Successfully merging this pull request may close these issues.
2 participants
@Soean @Mamaduka