Post Template: Don't fetch settings and templates for non-admin users #42845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Feature] Document Settings
Mamaduka
commented
Aug 1, 2022
Comment on lines
+31
to
+33
| const siteSettings = canUser( 'read', 'settings' ) | ||
| ? getEntityRecord( 'root', 'site' ) | ||
| : undefined; |
There was a problem hiding this comment.
The settings cannot be marked with a view or public context. Related Core PR: WordPress/wordpress-develop#2985
Mamaduka
commented
Aug 1, 2022
Comment on lines
+42
to
+47
| fetchedTemplates: canCreateTemplates | ||
| ? getEntityRecords( 'postType', 'wp_template', { | ||
| post_type: select( editorStore ).getCurrentPostType(), | ||
| per_page: -1, | ||
| } ) | ||
| : undefined, |
There was a problem hiding this comment.
Technically we only want to fetch templates when a user has caps to create them to keep the options array in sync. See #32744
|
Size Change: +26 B (0%) Total Size: 1.26 MB
ℹ️ View Unchanged
|
@Mamaduka How do I do this? I logged in as Editor but I don't see the option |
|
@getdave, what theme are you using? Try with TT1 or TT2. |
|
Is it such a problem to make the request and receive a 403 error? It means that we're making just one request (a |
|
It's not a problem to make 403 requests, but if we already know it resolves in one, I think it's better to avoid it.
The P.S. 403 errors usually get reported as bugs. See #29845. |
|
@noisysocks, should we merge this? |
If the cache is hot and doing this avoids a request then that sounds good to me 👍 |
noisysocks
approved these changes
Aug 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
A follow-up to #42705, also see #42413.
Why?
The editor should check permission before making requests when data isn't available for everyone.
How?
canUser( 'read', 'settings' )check before fetching site settings.canCreateTemplatesbefore fetching the templates.Testing Instructions
Screenshots or screencast