ColorGradientControl: Fix awkward padding in popover #43018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirka
added
[Package] Block editor
mirka
changed the title
|
Size Change: -6 B (0%) Total Size: 1.27 MB
ℹ️ View Unchanged
|
jasmussen
approved these changes
Aug 5, 2022
There was a problem hiding this comment.
Big improvement. Clunky padding above and left of the tabbar before:
Nice and compact after:
I'd encourage a code sanity check, but visually this is a good bugfix. (I still prefer the segmented control, but happy to try this 😅 )
I'm reminded that we have an opportunity to revisit the Swatch component as well — the swatch buttons are currently bigger inside the swatch panel than they are inside the ItemGroup. They should all be 20x20px:
That's separate to this PR, but it stood out.
Thank you for the work!
aaronrobertshaw
approved these changes
Aug 8, 2022
There was a problem hiding this comment.
Thanks for improving this @mirka 👍
The awkward padding introduced by #41900 has been addressed via this PR.
✅ Extra padding has been removed
✅ Color palette unit tests pass
Click for screenshot
While testing, I did notice the extraneous margin on the custom gradient picker. Perhaps this could be another small follow-up? That extra margin has been around for a long time by the looks of it.
Click for screenshot
jameskoster
requested changes
Aug 8, 2022
There was a problem hiding this comment.
I think there's a small regression here. Previously the swatch rows filled their container 100%:
Now there is a small gap at the end of each row:
Perhaps this was an oversight on the original PR though. If it's easy to address here I think that would be nice.
|
Removing the calculated width declaration on
|
|
@jameskoster Good catch, thanks! Fixed in e38b7a8:
|
@aaronrobertshaw Yes, I have a local branch with this fix and will make a PR soon 👍 |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #43014
What?
Fixes the awkward padding when the ColorGradientControl's tab switcher appears in a popover (#41900 (comment)).
Why?
There is actually a further redesign in the works, but that is going to take a little more time to achieve. So here is an easy, incremental step to make it less weird in the meantime.
How?
Testing Instructions
npm run devScreenshots or screencast
Before
After
CleanShot.2022-08-05.at.15.22.15.mp4