wp-env: Set core source to latest when null #43133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.28 MB ℹ️ View Unchanged
|
There was a problem hiding this comment.
How would you feel about moving the version default to parseConfig()? The conversion from null to "latest" might make the most sense there since we're really just parsing the null. Given that we won't need the fallback in withOverrides() and that we're already caching getLatestWordPressVersion(), that might be the most semantically correct.
noahtallen
force-pushed
the
fix-wp-env-null-core-source-bug
branch
from
49cd8b4 to
df37932
Compare
noahtallen
commented
Aug 12, 2022
noahtallen
commented
Aug 12, 2022
packages/env/lib/config/config.js
Outdated
| const env = allEnvs.reduce( ( result, environment ) => { | ||
| result[ environment ] = parseConfig( | ||
| const env = {}; | ||
| for ( const envName in allEnvs ) { |
There was a problem hiding this comment.
Moved away from reduce because it's a lot easier to do async/await in a plain for loop
noahtallen
added
the
[Type] Bug
There was a problem hiding this comment.
Thanks @noahtallen, I appreciate the changes you made, this approach looks cleaner. I'm unable to test it right now because of the way I've set up Docker (Something is going wrong with argument passing to docker-compose). I've added two suggestions that I think might be aligned with the current "parsing of null" idea, but, it's probably not a big deal.
noahtallen
force-pushed
the
fix-wp-env-null-core-source-bug
branch
from
8905b20 to
5c7914e
Compare
|
Nice, I like that idea! Added. |
noahtallen
added a commit
that referenced
this pull request
Aug 16, 2022
* Set core source to latest if config.core is null to fix a crash * Cache WordPress version to avoid extra network requests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
On trunk, there is a bug where if
.wp-env.jsonsets"core": null, wp-env will crash. This PR handles that case.Fixes #43222
Why?
The object spread operators which merge all of the configurations together override the default "latest version" string with this null value.
How?
In the overrides section of the config, we check if any of the core source values are still null, and then manually set the versions if needed. This means the core source should never be null.
Testing Instructions
nullnpx wp-env start --debug. Observe that the core source in the printed config file is null and that wp-env crashes.npx wp-env start --debug. It should start successfully, and you should see a git core source printed in the config file.