Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Columns Block: Add typography supports #43253

Merged
merged 1 commit into from
Aug 16, 2022

Conversation

aaronrobertshaw
Copy link
Contributor

@aaronrobertshaw aaronrobertshaw commented Aug 16, 2022

Related:

What?

Adopts typography supports for the Columns block.

Why?

  • Allows users to set typography styles that can apply across columns.
  • Advances efforts towards increased consistency of design tools across blocks.

How?

  • Opts into all typography block supports
  • Only exposes font size control as a default. Matches most common configuration to date.

Testing Instructions

  1. Open post editor and add a Columns block.
  2. Select a column configuration and add a paragraph to each column.
  3. Select the Columns block and trial adjusting all the available typography controls.
  4. Confirm styles are applied in the editor. Then save and check the frontend.
  5. Switch to the site editor and navigate to Global Styles > Blocks > Columns > Typography.
  6. Trial typography changes here and confirm these are applied in the preview as well as post editor/frontend.

Screenshots or screencast

Screen.Recording.2022-08-16.at.6.30.58.pm.mp4

@aaronrobertshaw aaronrobertshaw added [Type] Enhancement A suggestion for improvement. [Block] Columns Affects the Columns Block [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi labels Aug 16, 2022
@aaronrobertshaw aaronrobertshaw self-assigned this Aug 16, 2022
Copy link
Member

@ramonjd ramonjd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Typography values apply to paragraph and other text blocks correctly in the post editor
✅ In the site editor, setting typography values at both the individual block level, and Global Styles > Blocks > Columns > Typography, the column's text appears as expected
✅ Frontend is 1:1 with the editor
✅ Tested in block and classic themes

@aaronrobertshaw aaronrobertshaw merged commit 73ea68f into trunk Aug 16, 2022
@aaronrobertshaw aaronrobertshaw deleted the add/columns-typography-support branch August 16, 2022 10:03
@github-actions github-actions bot added this to the Gutenberg 14.0 milestone Aug 16, 2022
@femkreations femkreations added the Needs User Documentation Needs new user documentation label Sep 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Columns Affects the Columns Block [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi Needs User Documentation Needs new user documentation [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants