Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comments Pagination: Add typography support #43287

Merged
merged 1 commit into from
Aug 18, 2022
Merged

Comments Pagination: Add typography support #43287

merged 1 commit into from
Aug 18, 2022

Conversation

aaronrobertshaw
Copy link
Contributor

Related:

What?

Adds typography support to the Comments Pagination block.

Why?

  • Improves consistency of our design tools across blocks.
  • Adds higher level typography styling for the inner blocks of the Comments Pagination block.

How?

  • Opts into all typography supports.
  • Only the font size control will display by default.

Testing Instructions

  1. Edit a post with several comments, add a Comments block and select it.
  2. The font size control should be displayed by default.
  3. Test various typography settings ensuring styles are applied in the editor.
  4. Save and confirm the application on the frontend.
  5. Switch to the site editor, and select a page or template with a Comments block.
  6. Navigate to Global Styles > Blocks > Comments Pagination > Typography and apply typography styles there.
  7. Confirm the selected styles are reflected in the preview and on the frontend.

Screenshots or screencast

Screen.Recording.2022-08-17.at.10.54.34.am.mp4

@aaronrobertshaw aaronrobertshaw added [Type] Enhancement A suggestion for improvement. [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Feature] Typography Font and typography-related issues and PRs labels Aug 17, 2022
@aaronrobertshaw aaronrobertshaw self-assigned this Aug 17, 2022
@aaronrobertshaw aaronrobertshaw mentioned this pull request Aug 17, 2022
Open
6 tasks
talldan
talldan approved these changes Aug 18, 2022
View reviewed changes
Copy link
Contributor

@talldan talldan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@aaronrobertshaw aaronrobertshaw merged commit e3d5fc5 into trunk Aug 18, 2022
@aaronrobertshaw aaronrobertshaw deleted the add/typography-support-to-comments-pagination branch August 18, 2022 05:05
@github-actions github-actions bot added this to the Gutenberg 14.0 milestone Aug 18, 2022
@femkreations femkreations added the Needs User Documentation Needs new user documentation label Sep 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@talldan talldan talldan approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@ryanwelcher ryanwelcher Awaiting requested review from ryanwelcher

@juanmaguitar juanmaguitar Awaiting requested review from juanmaguitar juanmaguitar is a code owner

@fabiankaegy fabiankaegy Awaiting requested review from fabiankaegy fabiankaegy is a code owner

Assignees

@aaronrobertshaw aaronrobertshaw

Labels
[Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Feature] Typography Font and typography-related issues and PRs Needs User Documentation Needs new user documentation [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
Gutenberg 14.0
Development

Successfully merging this pull request may close these issues.
3 participants
@aaronrobertshaw @talldan @femkreations